cleanup: remove AsyncLocalStorage check #6147
Merged
+28
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjohansebas
approved these changes
Nov 5, 2024
UlisesGascon
approved these changes
Nov 7, 2024
wesleytodd
approved these changes
Nov 15, 2024
|
@Phillip9587 I realized I should have said this when I added my approval, but until we automate the history.md updates, can we continue manually adding things when they are code changes? I think we should have a discussion if test changes like this should have it, but I would rather folks have more in there than less until we automate or decide this is not necessary anymore. |
Phillip9587
force-pushed
the
remove-asynchooks-check
branch
from
6d22e00
to
92faae9
Compare
|
@wesleytodd I added the HISTORY.md entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the minimum supported node version set to v18 we can remove the AsyncLocalStorage support check as it was added in v13.10.0 and v12.17.0