Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package, fix vulnerbility, and fix unit test #6103

Closed
wants to merge 2 commits into from

Conversation

agungjati
Copy link

@agungjati agungjati commented Oct 30, 2024

Issue:
i have found 7 vulnerabilities (3 low, 1 moderate, 3 high)

Environment:

  • Windows 11
  • node JS v20.18.0

Tested:

  • lint
  • unit test
image

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @agungjati! Thanks for bring these ideas into the table and for preapre this PR ❤️

I believe that his PR does too much at once, so it will be hard to us to review all the changes and discuss about all the details together.I think we would likely accept a most of this if it was done in separate PRs with clear and small individual changes. Do you want to convert this into individual PRs?

Here you have a recent example of a similar situation: #6093

@UlisesGascon UlisesGascon self-assigned this Oct 30, 2024
@NewEraCracker
Copy link

NewEraCracker commented Oct 31, 2024

Do not bump cookie from 0.7.1 to 1.0.x

See: #6017 (comment)

Please don't just bump things without checking release notes for breaking changes.

#6017 (comment)

375505015-fab9d8f4-5160-4f1a-a431-a7420c8f7a79

@agungjati
Copy link
Author

Hi @UlisesGascon , these pr upgrade package, i have splited it
please review and merge, Thank you

@UlisesGascon
Copy link
Member

UlisesGascon commented Nov 1, 2024

Thanks for doing this work @agungjati! I will close this PR now, and we can discuss on each one if needed ;-)

I edited the PRs to make a cross reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants