Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics channel to layers #4408

Closed
wants to merge 1 commit into from

Conversation

Qard
Copy link

@Qard Qard commented Sep 17, 2020

This is a proof-of-concept implementation of the diagnostics_channel feature I'm working on in Node.js core. The value here is for APM products to be able to capture changes to routing state through the lifecycle of a request. This should of course not be merged until the module exists in Node.js itself. I'm just creating this now to prove the value to userland and to make sure a more complex framework can benefit from it.

I'll leave this as a draft PR until diagnostics_channel lands in Node.js core.

@dougwilson
Copy link
Contributor

Thank you so much @Qard ! Espeically if this can not be landed relatively soon, you should close this PR on this repo and instead open it on our upstream of the router: https://github.com/pillarjs/router . In the Express 5 branch, all of this code is deleted, so your changes would be lost if merged here. If your changes land in the router 1.x branch, they are automatically ported into the "legacy" Express 4.x code case, which is what your PR here is against.

@Qard
Copy link
Author

Qard commented Sep 17, 2020

Ah, cool. Didn't know about the backporting. I'll get this moved over. Thanks for the help! 👍

@Qard
Copy link
Author

Qard commented Sep 17, 2020

New PR opened here: pillarjs/router#96, closing this now. :)

@Qard Qard closed this Sep 17, 2020
@Qard Qard deleted the diagnostics-channel branch September 17, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants