dig: use our dig fork #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexisvisco
commented
Sep 5, 2023
| @@ -57,18 +59,18 @@ func (r *Router) Delete(path string, handler any) { | |||
| r.Route(http.MethodDelete, path, handler) | |||
| } | |||
|
|
|||
| func (r *Router) getHttpHandler(handler any) http.Handler { | |||
| func (r *Router) getHttpHandler(handler any) (http.Handler, error) { | |||
There was a problem hiding this comment.
Add error return type here
| Container struct { | ||
| values map[reflect.Type]reflect.Value | ||
| } | ||
| AppEnv string |
There was a problem hiding this comment.
Add type alias string for AppEnv (for convenience)
| if app.Env == "" { | ||
| app.Env = AppEnvDevelopment | ||
| } | ||
|
|
||
| if app.Logger == nil { | ||
| if app.Env == AppEnvProduction { | ||
| app.Logger = panicOnError(zap.NewProduction()) | ||
| app.Logger = lo.Must(zap.NewProduction()) |
There was a problem hiding this comment.
Use of lo library to just not create code not tested
| } | ||
| } | ||
| return returnValues, nil | ||
| func ProvideSingleValueFunc[T any](v T) func() T { |
There was a problem hiding this comment.
Add utility func to pass single value as function for Provide
Comment on lines
+16
to
+23
| // Note on github.com/expectedsh/dig, this is a fork of go.uber.org/dig | ||
| // Our fork is needed to add outputs informations for an invoke | ||
| // A merge request is opened, waiting for the merge | ||
| // When the merge will occur we could remove this fork and use the official dig package | ||
| // | ||
| // The fork contains two branches : | ||
| // - the master branch is the same as the official dig package | ||
| // - the expected branch contains the changes we made to add outputs informations for an invoke and replaced go.mod module name |
There was a problem hiding this comment.
Our dig is temporary but if the merge request is declined, we can handle that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.