Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for concept exercise log-line-parser #192

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Add a test for concept exercise log-line-parser #192

merged 1 commit into from
Oct 31, 2023

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Oct 30, 2023

I've had two mentoring sessions for this exercise where the student was extracting the message with something like

. / ":" | .[1] | ...

Adding a test where the message contains colons to expose that error.

@glennj glennj added the x:rep/small Small amount of reputation label Oct 30, 2023
@glennj glennj requested a review from IsaacG October 30, 2023 18:47
@glennj glennj merged commit 4f13115 into exercism:main Oct 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacG IsaacG IsaacG approved these changes

Assignees
No one assigned
Labels
x:rep/small Small amount of reputation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glennj @IsaacG