Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch track to jq version 1.7 #191

Merged
merged 14 commits into from
Oct 26, 2023
Merged

Switch track to jq version 1.7 #191

merged 14 commits into from
Oct 26, 2023

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Oct 25, 2023

Summary

  • update documentation
  • For CI, update the github workflows to download a standalone jq binary from the jqlang/jq release page (ubuntu 22.04 offerss v1.6)

Checklist

  • If docs where changed, run ./bin/configlet generate to ensure all documents are properly generated.
  • CI is green

@glennj glennj marked this pull request as draft October 26, 2023 00:33
@glennj glennj marked this pull request as ready for review October 26, 2023 01:16
@glennj
Copy link
Contributor Author

glennj commented Oct 26, 2023

@IsaacG I've got CI working now (files .github/workflow/{ci,pr}.yml), if you want to have another look.

I'm going to hold off merging until the jq-test-runner is updated for v1.7

@glennj glennj marked this pull request as draft October 26, 2023 01:18
@glennj glennj marked this pull request as ready for review October 26, 2023 01:49
Comment on lines +5 to +9
## Version Information

As of October 2023, the current jq release is version 1.7.
Most Linux package managers will install the previous release, version 1.6.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we specify somewhere that the online editor will use jq 1.7? (Not necessarily in this file).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 5baffb2

@glennj glennj merged commit 3caa838 into exercism:main Oct 26, 2023
2 checks passed
@glennj glennj deleted the version-1.7 branch October 26, 2023 19:57
@glennj glennj mentioned this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants