All solutions of samuka smk #78
Conversation
… in url example (http://domain.com/service/local/artifact/maven/content?r=private&g=com.myapp&a=my-app-catalog&v=5.31.3&p=war), if we do not use accents ', at the time of passing the url as parameter the scripts (eg get_file.sh), the bash interprets '&' character as (end of command, send command to backgroud). I tried to use these accents in the declaration of the manifesto, by calling the class puppi::project::war, however the manifests of puppi write scripts to deploy wrong.
…e contain variations
…tBash), (2.FeatureSetDestWarFileName), 3.FeaturePassingParametersInHTTPAauthInPuppiProjectWar)
| @@ -211,7 +226,7 @@ | |||
| puppi::deploy { "${name}-Retrieve_WAR": | |||
| priority => '20' , | |||
| command => 'get_file.sh' , | |||
| arguments => "-s ${source} -a ${real_always_deploy}" , | |||
| arguments => "-s '${source}' -a '${real_always_deploy}' -f '${war_file}' -u '${http_user}' -p '${http_pass}'" , | |||
There was a problem hiding this comment.
What happens here when http_user and http_user and http_pass are left blank?
Probably an error?
There was a problem hiding this comment.
BTW, have you tried to pass username and password directyl in the url?
IE: http://user:mypw@host:/path/file.war
That should work, without the need of setting extra params.
There was a problem hiding this comment.
Hy Guys,
This is an optional solution, use any way they wish. My intention to insert
these new options was formally declare in the manifest as a way to explain
how to pass the unsuspecting user and password of http, since we have no
explanatory documentation on http authentication, (I even hit head until I
remember that gave to pass the username and password via http url)
Thanks,
Samuka~Smk
2013/6/24 Alessandro Franceschi [email protected]
In manifests/project/war.pp:
@@ -211,7 +226,7 @@
puppi::deploy { "${name}-Retrieve_WAR":
priority => '20' ,
command => 'get_file.sh' ,
arguments => "-s ${source} -a ${real_always_deploy}" ,arguments => "-s '${source}' -a '${real_always_deploy}' -f '${war_file}' -u '${http_user}' -p '${http_pass}'" ,BTW, have you tried to pass username and password directyl in the url?
IE: http://user:mypw@host:/path/file.war
That should work, without the need to setting extra params.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/78/files#r4843197
.
There was a problem hiding this comment.
If the approach of passing username and password directly in the url works, I would stick to it and eventually explain it better in the docs.
There was a problem hiding this comment.
Perfect!,
The way you guys found better, If you want to close the pull request # 76
(Feature passing parameters in http aauth puppi project in war),
provided that improved documentation and is clear for new users, feel free.
Thanks,
SamukaSMk
2013/6/24 Alessandro Franceschi [email protected]
In manifests/project/war.pp:
@@ -211,7 +226,7 @@
puppi::deploy { "${name}-Retrieve_WAR":
priority => '20' ,
command => 'get_file.sh' ,
arguments => "-s ${source} -a ${real_always_deploy}" ,arguments => "-s '${source}' -a '${real_always_deploy}' -f '${war_file}' -u '${http_user}' -p '${http_pass}'" ,If the approach of passing username and password directly in the url
works, I would stick to it and eventually explain it better in the docs.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/78/files#r4843641
.
All solutions proposed by me @samukasmk, merged into a single branch.