🐛 rewards: fix released calculation #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐛 rewards: fix released calculation
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix-review-130 #725 +/- ##
==================================================
- Coverage 89.19% 89.14% -0.05%
==================================================
Files 18 18
Lines 2027 2027
Branches 273 332 +59
==================================================
- Hits 1808 1807 -1
+ Misses 208 207 -1
- Partials 11 13 +2 ☔ View full report in Codecov by Sentry. |
cruzdanilo
force-pushed
the
fix-review-130
branch
from
3dfd6a6
to
e71f770
Compare
cruzdanilo
force-pushed
the
fix-review-154
branch
from
e676ae4
to
5d1a282
Compare
cruzdanilo
force-pushed
the
fix-review-130
branch
from
e71f770
to
6372ac9
Compare
cruzdanilo
force-pushed
the
fix-review-154
branch
from
5d1a282
to
cd10b95
Compare
cruzdanilo
force-pushed
the
fix-review-130
branch
from
6372ac9
to
bb38a54
Compare
cruzdanilo
force-pushed
the
fix-review-154
branch
from
cd10b95
to
afd8de1
Compare
itofarina
reviewed
Jun 3, 2024
contracts/RewardsController.sol
Outdated
| /// @param market The market to get the release rate. | ||
| /// @param reward The reward asset. | ||
| /// @return The release reward rate. | ||
| function releaseRate(Market market, ERC20 reward) external view returns (uint256) { |
There was a problem hiding this comment.
@santichez can we add coverage for this new function?
santichez
force-pushed
the
fix-review-154
branch
5 times, most recently
from
2f5c8ba
to
ca93c22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.