Fixed hide-corners bug #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewlsh
requested changes
Apr 30, 2021
| @@ -150,6 +150,31 @@ function has_icon_shadow() { | |||
| function remove_text_shadow() { | |||
| Panel.remove_style_class_name('dpt-panel-text-shadow'); | |||
| } | |||
| /** | |||
There was a problem hiding this comment.
Remove register_hide_corners - you don't need a dynamic stylesheet for a static style.
| @@ -206,7 +221,7 @@ function initialize_settings() { | |||
|
|
|||
| for (let i = Theming.stylesheets.length - 1; i >= 0; i--) { | |||
| let stylesheet = Theming.stylesheets[i]; | |||
| if (stylesheet.indexOf('background') !== -1 && stylesheet.indexOf('panel-') !== -1) { | |||
| if (stylesheet.indexOf('background') !== -1 && stylesheet.indexOf('panel-') !== -1 && stylesheet.indexOf('panel-hide-corners') == -1) { | |||
| @@ -247,7 +262,7 @@ function initialize_settings() { | |||
|
|
|||
| for (let i = Theming.stylesheets.length - 1; i >= 0; i--) { | |||
| let stylesheet = Theming.stylesheets[i]; | |||
| if (stylesheet.indexOf('background') !== -1 && stylesheet.indexOf('panel-') !== -1) { | |||
| if (stylesheet.indexOf('background') !== -1 && stylesheet.indexOf('panel-') !== -1 && stylesheet.indexOf('panel-hide-corners') == -1) { | |||
| @@ -285,7 +300,7 @@ function initialize_settings() { | |||
|
|
|||
| for (let i = Theming.stylesheets.length - 1; i >= 0; i--) { | |||
| let stylesheet = Theming.stylesheets[i]; | |||
| if (stylesheet.indexOf('background') !== -1 && stylesheet.indexOf('panel.dpt.css') !== -1) { | |||
| if (stylesheet.indexOf('background') !== -1 && stylesheet.indexOf('panel.dpt.css') !== -1 && stylesheet.indexOf('panel-hide-corners') == -1) { | |||
[email protected]/extension.js
Outdated
| if (Settings.get_enable_text_color()) { | ||
| if (text !== null) { | ||
| Theming.set_text_color(); | ||
| } else { | ||
| log('[Dynamic Panel Transparency] Failed to enabled text coloring.'); | ||
| } | ||
| } | ||
|
|
||
| /* Register hide corners. */ | ||
| let hide_corners = Theming.register_hide_corners(); |
There was a problem hiding this comment.
Suggested change
| let hide_corners = Theming.register_hide_corners(); |
[email protected]/extension.js
Outdated
| if (Settings.get_enable_text_color()) { | ||
| if (text !== null) { | ||
| Theming.set_text_color(); | ||
| } else { | ||
| log('[Dynamic Panel Transparency] Failed to enabled text coloring.'); | ||
| } | ||
| } | ||
|
|
||
| /* Register hide corners. */ |
There was a problem hiding this comment.
Suggested change
| /* Register hide corners. */ |
| let hide_corners = Theming.register_hide_corners(); | ||
|
|
||
| if (Settings.get_hide_corners()) { | ||
| if (hide_corners !== null) { |
[email protected]/stylesheet.css
Outdated
| @@ -20,3 +20,6 @@ | |||
| background-image: none; | |||
| } | |||
|
|
|||
| /* Prevents overlapping of corners + top bar when using transparency */ | |||
| .panel-corner { | |||
| -panel-corner-border-width: 0px;} | |||
There was a problem hiding this comment.
Suggested change
| -panel-corner-border-width: 0px;} | |
| -panel-corner-border-width: 0px; | |
| } | |
[email protected]/extension.js
Outdated
| @@ -106,14 +106,25 @@ function modify_panel() { | |||
| /* Register text color styling. */ | |||
| let [text, icon, arrow] = Theming.register_text_color(Settings.get_text_color()); // eslint-disable-line no-unused-vars | |||
| let [maximized_text, maximized_icon, maximized_arrow] = Theming.register_text_color(Settings.get_maximized_text_color(), 'maximized'); // eslint-disable-line no-unused-vars | |||
|
|
|||
|
@ajbucci I reviewed this and listed the necessary changes, I'll apply them myself and commit this weekend unless you'd like to. |
Co-authored-by: Evan Welsh <[email protected]>
Co-authored-by: Evan Welsh <[email protected]>
Co-authored-by: Evan Welsh <[email protected]>
Co-authored-by: Evan Welsh <[email protected]>
|
@ewlsh Thanks for taking the time to review the changes! I'm a bit shot at the moment as my wife and I just had our first child this past week and are still adjusting. Go ahead and apply your changes/suggestions this weekend. Thanks again! |
|
Changes were manually applied, thank you 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this is my first pull request so apologies if I haven't done this quite right! This should fix the issue "Panel corners black after toggling overview"
Fixes #139