Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Error when linking to absolute URLs with absolute links to images #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eviltrout
Copy link
Contributor

Matching URLs with regular expressions is tough! However, this approach fixes issues when linking to absolute URLs with absolute image URLs inside them.

@ashb
Copy link
Collaborator

ashb commented Jul 29, 2014

At times I wish I hadn't built this around regexps :( That 🚢 has long since sailed.

Change looks okay - could you look at what happened to the node 0.8 tests in travis?

@eviltrout
Copy link
Contributor Author

Looks like a random npm failure to me? I didn't change any deps.

@ashb
Copy link
Collaborator

ashb commented Jul 30, 2014

Hmmmm its seemed to have been failing for about a month https://travis-ci.org/evilstreak/markdown-js/pull_requests

Bet its some annoyance in a dep that no longer supports node.js 0.8.... Bah.

So we either need to pin grunt (at a guess) to an older version, or drop support for 0.10... thoughts either way?

@eviltrout
Copy link
Contributor Author

We only use it in browsers so I have no insight into node versions. But 0.8 is quite old isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants