Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roletimelock #36

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

TheDarkBatman2
Copy link
Contributor

Please check the playtime pull request first. thanks.

now it will be easier to add code related to the playtime of a certain player
@evilfactory
Copy link
Owner

Fix the conflicts

@TheDarkBatman2
Copy link
Contributor Author

Done !

@evilfactory
Copy link
Owner

Okay so there's some changes that need to be done for this work reasonably.

  • Role locks shouldn't be based on time, but instead point accomplishments (eg: you need to gain 5000 points before unlocking the roles, if you already have 5000 points, its already accomplished by default)
  • No roles will actually be locked, if there's no security guards, it will pick one anyway, people with it unlocked will just have priority
  • Use the jobsAssigned hook instead of patching the method, since it's already there by default
  • Put any unrelated changes to role locks in a separate PR (Traitormod.GetPoints instead of Traitormod.GetData)

@TheDarkBatman2
Copy link
Contributor Author

Ok i will do them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants