Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mypy rules and version. #1343

Open
wants to merge 89 commits into
base: main
Choose a base branch
from
Open

Update Mypy rules and version. #1343

wants to merge 89 commits into from
+484 −339

Commits on Oct 19, 2024

  1. Add default value for options in base Metric class.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    1e7526c View commit details
    Browse the repository at this point in the history

  2. Update mypy version and rules.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    e4c630e View commit details
    Browse the repository at this point in the history

  3. Ignore signature missmatch due to skiprows.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    1d9d867 View commit details
    Browse the repository at this point in the history

  4. Add named argument label for tests TestRecallByClass, TestPrecisionBy… 

    …Class.
    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    1a055f2 View commit details
    Browse the repository at this point in the history

  5. Make TestRenderer to be generics.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    8b3e0fb View commit details
    Browse the repository at this point in the history

  6. Make MetricRenderer generic.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    ad40f78 View commit details
    Browse the repository at this point in the history

  7. Ignore assignment for different versions of pydantic.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    af0faa9 View commit details
    Browse the repository at this point in the history

  8. Add missing return for method get_condition_from_reference

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    8c602eb View commit details
    Browse the repository at this point in the history

  9. Fix types in visualizations functions.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    4996c5d View commit details
    Browse the repository at this point in the history

  10. Fix types in html_widgets get_lift_plot_data function.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    252c1ed View commit details
    Browse the repository at this point in the history

  11. Replace columns list assignment with explicit pd.Index

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    698072b View commit details
    Browse the repository at this point in the history

  12. Explicit check for LocalStorage in app as we require it.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    03f6a62 View commit details
    Browse the repository at this point in the history

  13. Fix problem with missing reference in TestCorrelationChanges.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    25a20f4 View commit details
    Browse the repository at this point in the history

  14. Ignore type error in get_component.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    c825de7 View commit details
    Browse the repository at this point in the history

  15. Make Recsys tests generic.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    1f4dccf View commit details
    Browse the repository at this point in the history

  16. Add types in _feature_render_html.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    df28cda View commit details
    Browse the repository at this point in the history

  17. Fix types errors in text_descriptors_drift_metric.py

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    f101d6f View commit details
    Browse the repository at this point in the history

  18. Add Optional to column argument in calculate_numerical_correlation.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    cad388a View commit details
    Browse the repository at this point in the history

  19. Fix typing errors in classification_dummy_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    e90715b View commit details
    Browse the repository at this point in the history

  20. Fix typing errors in dataset_correlations_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    840bb3a View commit details
    Browse the repository at this point in the history

  21. Ignore call overloads in visualizations.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    bb0c0ba View commit details
    Browse the repository at this point in the history

  22. Fix typing errors in column_drift_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    608c447 View commit details
    Browse the repository at this point in the history

  23. Fix typing errors in data_drift_table.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    82d9370 View commit details
    Browse the repository at this point in the history

  24. Ignore numpy typing errors in regression_dummy_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    d8b65a2 View commit details
    Browse the repository at this point in the history

  25. Add optional to ref argument in plot_cat_cat_rel.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    1eaab5f View commit details
    Browse the repository at this point in the history

  26. Check that reference data is present if required in column_summary_me… 

    …tric.
    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    da2f116 View commit details
    Browse the repository at this point in the history

  27. Add explicit check of reference data is not None before using it in c… 

    …olumn_correlations_metric.
    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    ea33fdb View commit details
    Browse the repository at this point in the history

  28. Fix type hints in ndcg_k.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    083a3dd View commit details
    Browse the repository at this point in the history

  29. Add explicit reference_data check and ignore numpy typing errors in r… 

    …egression_quality.
    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    10e94da View commit details
    Browse the repository at this point in the history

  30. Fix variable reuse in spark/visualizations.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    4a6b65c View commit details
    Browse the repository at this point in the history

  31. Ignore numpy typing errors and fix typing for correlations call in da… 

    …ta_quality.
    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    52daef9 View commit details
    Browse the repository at this point in the history

  32. Replace values with to_numpy in quality_by_class_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    e7dc5ef View commit details
    Browse the repository at this point in the history

  33. Explicit check for reference data and ignore numpy errors in regressi… 

    …on_performance_metrics.
    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    3345282 View commit details
    Browse the repository at this point in the history

  34. Fix typing for _make_df_for_plot in top_er

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    6863180 View commit details
    Browse the repository at this point in the history

  35. Replace values with to_numpy in cramer_von_mises_stattest.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    d76a95f View commit details
    Browse the repository at this point in the history

  36. Add type hint in histogram.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    7fd9426 View commit details
    Browse the repository at this point in the history

  37. Replace values with to_numpy in fisher_exact_stattest.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    155020b View commit details
    Browse the repository at this point in the history

  38. Replace values with to_numpy in hellinger_distance.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    040c639 View commit details
    Browse the repository at this point in the history

  39. Replace values with to_numpy in mmd_stattest. 

    Fix reuse of variables.
    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    2824306 View commit details
    Browse the repository at this point in the history

  40. Fix type hints in z_stattest.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    06db79b View commit details
    Browse the repository at this point in the history

  41. Fix reuse variables in utils.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    db62d7b View commit details
    Browse the repository at this point in the history

  42. Convert to proper types in class_separation_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    27c75e0 View commit details
    Browse the repository at this point in the history

  43. Add type hints in lift_curve_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    33efb53 View commit details
    Browse the repository at this point in the history

  44. Replace values with to_numpy in lift_table_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    5e5d39a View commit details
    Browse the repository at this point in the history

  45. Replace values with to_numpy and add type hints in pr_curve_metric.py.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    049c95f View commit details
    Browse the repository at this point in the history

  46. Replace values with to_numpy and add type hints in pr_table_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    d8d5070 View commit details
    Browse the repository at this point in the history

  47. Use proper variable in quality_by_feature_table.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    a319bd2 View commit details
    Browse the repository at this point in the history

  48. Fix default options value in metrics.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    5e6efbb View commit details
    Browse the repository at this point in the history

  49. Replace values to to_numpy in roc_curve_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    f7a9246 View commit details
    Browse the repository at this point in the history

  50. Fix typing errors in error_in_time.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    bf00753 View commit details
    Browse the repository at this point in the history

  51. Fix typing for results in abs_perc_error_in_time.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    454954a View commit details
    Browse the repository at this point in the history

  52. Fix typing for DataFrame processing in error_distribution.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    7451863 View commit details
    Browse the repository at this point in the history

  53. Fix typing errors in error_normality.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    62b81ad View commit details
    Browse the repository at this point in the history

  54. Fix typing errors in predicted_and_actual_in_time.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    25b2bcc View commit details
    Browse the repository at this point in the history

  55. Add explicit check for reference data in target_by_features_table.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    a8d4999 View commit details
    Browse the repository at this point in the history

  56. Ignore import of infer_dtype_from_object in data_integrity_tests.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    9db8ab7 View commit details
    Browse the repository at this point in the history

  57. Fix types in utils.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    45d8d62 View commit details
    Browse the repository at this point in the history

  58. User proper types in pydantic_utils.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    48e8db8 View commit details
    Browse the repository at this point in the history

  59. Fix types in test_suites.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    a38319b View commit details
    Browse the repository at this point in the history

  60. Ignore typing error with generic operation in reports.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    f77856d View commit details
    Browse the repository at this point in the history

  61. Fix typing in utils.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    34b4f58 View commit details
    Browse the repository at this point in the history

  62. Ignore typing error in classification_performance.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    29d3bb2 View commit details
    Browse the repository at this point in the history

  63. Fix type conversion in regression_performance.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    5b44bf6 View commit details
    Browse the repository at this point in the history

  64. Explicitly provide column_name to super class in OOV_words_percentage… 

    …_feature.
    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    3576774 View commit details
    Browse the repository at this point in the history

  65. Make proper calls to super init in hf_feature.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    5849c43 View commit details
    Browse the repository at this point in the history

  66. Make proper return type in __iter__ methods in base_suite.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    895189c View commit details
    Browse the repository at this point in the history

  67. Move column_name to super.__init__ call in non_letter_character_perce… 

    …ntage_feature.
    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    e5bd73d View commit details
    Browse the repository at this point in the history

  68. Move column_name to super.__init__ call in features.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    3c56424 View commit details
    Browse the repository at this point in the history

  69. Replace values with to_numpy in feature_importance.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    91b5a12 View commit details
    Browse the repository at this point in the history

  70. Ignore type error in data_preprocessing.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    7a92b2a View commit details
    Browse the repository at this point in the history

  71. Explicit check for exclude argument in options/base.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    321413f View commit details
    Browse the repository at this point in the history

  72. Make a result_type classmethod but ignore typing error in base_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    c640d29 View commit details
    Browse the repository at this point in the history

  73. Fix typing and ignore type collision in subclass in metric_results.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    e386788 View commit details
    Browse the repository at this point in the history

  74. Fix deduplication in get_additional_features.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    1504d4c View commit details
    Browse the repository at this point in the history

  75. Ignore type errors in python_engine.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    fe0be77 View commit details
    Browse the repository at this point in the history

  76. Add convert index to series in data_operations.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    1f9be5b View commit details
    Browse the repository at this point in the history

  77. Fix variable reuse in text_part_feature.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    41aae0a View commit details
    Browse the repository at this point in the history

  78. Add type hint and ignore typing error in html_widgets.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    abb1cdb View commit details
    Browse the repository at this point in the history

  79. Ignore type errors in column_value_list_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    626058a View commit details
    Browse the repository at this point in the history

  80. Move feature_type to super.__init__ in openai_feature.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    e5beb3b View commit details
    Browse the repository at this point in the history

  81. Enable typechecking for report.py.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    9324abb View commit details
    Browse the repository at this point in the history

  82. Enable typechecking in get_distr in scores_distribution.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    ed16d12 View commit details
    Browse the repository at this point in the history

  83. Add type hints in column_category_metric.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    01aa329 View commit details
    Browse the repository at this point in the history

  84. Fix tests.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    529ce39 View commit details
    Browse the repository at this point in the history

  85. Set min pydantic to 2.2.1

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    b4be547 View commit details
    Browse the repository at this point in the history

  86. Revert pedantic version change and configure for pydantic v1.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    f1ce99b View commit details
    Browse the repository at this point in the history

  87. Add pandas-stubs dependency.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    1efca34 View commit details
    Browse the repository at this point in the history

  88. Fix another typing errors.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    d7e9267 View commit details
    Browse the repository at this point in the history

  89. Fix another typing errors.

    @Liraim
    Liraim committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    b0faa1c View commit details
    Browse the repository at this point in the history