-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added message cleaner configuration. Added database schema. Added micronaut details for DomainEventDispatcher. Fixed rabbitmq docs. #42
base: master
Are you sure you want to change the base?
Conversation
==== Configuring a cleaner | ||
|
||
Cdc can automatically remove old messages from message table and received_message table. | ||
Example configuration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please describe what this configuration does.
Also, please have properties for configuring received_message
table too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
... | ||
---- | ||
|
||
If pipeline is specified, pipeline database configuration is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would the user NOT want to specify the pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. But probably we discussed this option when I was working on implementation.
... | ||
---- | ||
|
||
Full list of configuration properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something seems to be missing here that explains what EVENTUATE_CDC_CLEANER_C3
is, e.g. eventuate.cdc.cleaner
is some root property name, c3
is the name of a specific cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will add
@@ -595,6 +595,87 @@ The Eventuate Tram CDC supports `eventuate-tram` and `eventuate-local` | |||
|
|||
|=== | |||
|
|||
==== Configuring a cleaner | |||
|
|||
Cdc can automatically remove old messages from message table and received_message table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should explain that you configure one or more named cleaners.
Each clean can clean a message table and/or a received_message table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will add that
@@ -396,7 +396,7 @@ If polling fails, reader will try again using the specified interval. | |||
| Pipeline property name | |||
|
|||
| eventuate.database.schema | |||
| Schema which is listened by the CDC service | |||
| Schema which is listened by the CDC service (use `NONE` for default from jdbc connection) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think eventuate.database.schema
is used to configure the CDC.
It's used to configure the application/service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used. Each reader has datasource. But I added info for application.
|
||
In default eventuate images, tables are located in 'eventuate' schema. | ||
If you created necessary tables (see further) in some custom schema, please specify it in `eventuate.database.schema` property or use value `NONE` for it. | ||
See <<Single pipeline - Pipeline Properties>> and <<Configuring a pipeline>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a hyperlink? If not, it should be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
If you created necessary tables (see further) in some custom schema, please specify it in `eventuate.database.schema` property or use value `NONE` for it. | ||
See <<Single pipeline - Pipeline Properties>> and <<Configuring a pipeline>> | ||
|
||
==== Mysql schema example for eventuate local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalization:
- eventuate => Eventuate
- Mysql => MySQL
); | ||
---- | ||
|
||
==== Full Database Schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move these links into the respective sections.
Please use proper links:
* [MySQL schema for ...](...)
|
||
==== `OFFSET_STORE` table | ||
|
||
When publishing messages to Apache ActiveMQ, RabbitMQ, Redis, the MySql binlog reader records the current binlog position in this table. | ||
|
||
---- | ||
CREATE TABLE eventuate.offset_store( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it always eventuate.
?
@@ -807,16 +896,145 @@ The CDC service requires various infrastructure services including: | |||
The Eventuate CDC service requires several tables. | |||
The Eventuate MySQL and Postgres images define these tables. | |||
|
|||
|
|||
In default eventuate images, tables are located in 'eventuate' schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typos and capitalization: 'In the default Eventuate images'
No description provided.