Allow Keep Alives for 201 & 404 Responses. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 404/201 response does not indicate that the connection is unviable.
|
i like to see this merged to master. i was doing the same on my fork... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our app (used internally in @reevoo) is posting many (1000/s) small requests over SSL with certificate verification on either side. Connection setups are very expensive, so we use keep alive and connection recycling.
Our service responds with a 201 when a record is posted and a 404 when a get on a missing record happens.
This patch means that only 5xx responses force a connection reset.
I've also added some test coverage.
Let me know what you think.