MET-6211 Process review

europeana · Oct 11, 2024 · 8a2d52e · 8a2d52e
1 parent 5c2e09b
commit 8a2d52e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...main/java/eu/europeana/metis/authentication/rest/controller/AuthenticationController.java b/...main/java/eu/europeana/metis/authentication/rest/controller/AuthenticationController.java
@@ -207,7 +207,7 @@ public void updateUserToMakeAdmin(@RequestHeader("Authorization") String authori
     if (emailParameter == null || StringUtils.isBlank(emailParameter.getEmail())) {
       throw new BadContentException("userEmailToMakeAdmin is empty");
     }
-    String accessToken = authenticationService.validateAuthorizationHeaderWithAccessToken(authorization);
+    final String accessToken = authenticationService.validateAuthorizationHeaderWithAccessToken(authorization);
     if (!authenticationService.isUserAdmin(accessToken)) {
       throw new UserUnauthorizedException(ACTION_NOT_ALLOWED_FOR_USER);
     }

diff --git a/...-common/metis-common-utils/src/main/java/eu/europeana/metis/utils/CommonStringValues.java b/...-common/metis-common-utils/src/main/java/eu/europeana/metis/utils/CommonStringValues.java
@@ -31,7 +31,7 @@ private CommonStringValues() {
 
   /**
    * Sanitized input value from Logging injection attacks(javasecurity:S5145).
-   * <p>Replaces CR and LF characters with a safe value e.g. '_'.</p>
+   * <p>Replaces CR and LF characters with a safe value e.g. ""(empty string).</p>
    *
    * @param input the input
    * @return the sanitized input, safe for logging