Merge pull request #2 from europeana/feat/MET-6218_replace_unknown_wi…

…th_legacy_depublication_reason MET-6218 Replace unknown with legacy depublication reason
europeana · Oct 18, 2024 · 192602a · 192602a
2 parents d66b7a9 + e4a8a77
commit 192602a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/metis-core-common/src/main/java/eu/europeana/metis/core/rest/DepublishRecordIdView.java b/metis-core-common/src/main/java/eu/europeana/metis/core/rest/DepublishRecordIdView.java
@@ -29,7 +29,7 @@ public DepublishRecordIdView(DepublishRecordId depublishRecordId) {
     this.depublicationStatus = DepublicationStatus
         .convertFromModelToView(depublishRecordId.getDepublicationStatus());
     this.depublicationReason =
-        depublishRecordId.getDepublicationReason() == null ? DepublicationReason.UNKNOWN.toString()
+        depublishRecordId.getDepublicationReason() == null ? DepublicationReason.LEGACY.toString()
             : depublishRecordId.getDepublicationReason().toString();
   }
 
@@ -50,7 +50,7 @@ public String getDepublicationReason() {
   }
 
   /**
-   * The status of this record with regards to (de)publication.
+   * The status of this record regarding (de)publication.
    */
   public enum DepublicationStatus {
     DEPUBLISHED, PENDING;

diff --git a/...st/src/main/java/eu/europeana/metis/core/rest/controller/DepublishRecordIdController.java b/...st/src/main/java/eu/europeana/metis/core/rest/controller/DepublishRecordIdController.java
@@ -238,11 +238,14 @@ public WorkflowExecution addDepublishWorkflowInQueueOfWorkflowExecutions(
       MediaType.APPLICATION_JSON_VALUE, MediaType.APPLICATION_XML_VALUE})
   @ResponseStatus(HttpStatus.OK)
   public List<DepublicationReasonView> getAllDepublicationReasons(){
-    return Arrays.stream(DepublicationReason.values()).filter(value -> value != DepublicationReason.UNKNOWN)
+    return Arrays.stream(DepublicationReason.values()).filter(value -> value != DepublicationReason.LEGACY)
                  .map(DepublicationReasonView::new).toList();
   }
 
-  private static class DepublicationReasonView {
+  /**
+   * The view class for a depublication reason
+   */
+  public static class DepublicationReasonView {
 
     @JsonProperty("name")
     private final String name;

diff --git a/...-core-service/src/main/java/eu/europeana/metis/core/service/DepublishRecordIdService.java b/...-core-service/src/main/java/eu/europeana/metis/core/service/DepublishRecordIdService.java
@@ -189,7 +189,7 @@ public WorkflowExecution createAndAddInQueueDepublishWorkflowExecution(
     // Authorize.
     authorizer.authorizeReadExistingDatasetById(metisUserView, datasetId);
 
-    if (depublicationReason == DepublicationReason.UNKNOWN) {
+    if (depublicationReason == DepublicationReason.LEGACY) {
       throw new PluginExecutionNotAllowed(
           format("Depublication reason %s, is not allowed", depublicationReason));
     }