Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: not allow state operations without a TF_DEMUX_ALLOW_STATE_COMMANDS environment #17

Merged
merged 13 commits into from
Apr 2, 2024

Conversation

c4po
Copy link
Contributor

@c4po c4po commented Mar 19, 2024

Description

Update terraform-demux to not allow state operations without a TF_DEMUX_ALLOW_STATE_COMMANDS env variable

  • for terraform 1.5.0+ terraform import command need a TF_DEMUX_ALLOW_STATE_COMMANDS=true env variable
  • for terraform 1.1.0+ terraform state mv command need a TF_DEMUX_ALLOW_STATE_COMMANDS=true env variable
  • for terraform 1.7.0+ terraform state rm command need a TF_DEMUX_ALLOW_STATE_COMMANDS=true env variable

Context / Why are we making this change?

DP-4512

Testing and QA Plan

How has this work been tested or QA'd?

Impact

What are the implications of these changes? Are there any cross-cutting concerns to keep in mind?

@c4po c4po requested review from ericnorris and a team March 19, 2024 18:58
@c4po c4po changed the title feat: not allow state operations without a –force flag feat: not allow state operations without a TF_DEMUX_ALLOW_STATE_COMMANDS environment Apr 2, 2024
@c4po c4po requested a review from ericnorris April 2, 2024 14:58
@c4po c4po requested a review from ericnorris April 2, 2024 15:10
@c4po c4po requested a review from ericnorris April 2, 2024 15:20
Copy link
Contributor

@ericnorris ericnorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I wonder if we should consider this a "breaking change" and bump this to v2?

@c4po c4po merged commit 01619ad into main Apr 2, 2024
2 checks passed
@c4po c4po deleted the force-state branch April 2, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants