Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gsoc subscribe #4727

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

feat: gsoc subscribe #4727

wants to merge 32 commits into from

Conversation

nugaon
Copy link
Member

@nugaon nugaon commented Jul 17, 2024

Introducing /gsoc/subscribe/{address} endpoint which opens a websocket channel for reading incoming payloads of the Single Owner Chunk under the defined address.

Closes #4333

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@nugaon nugaon marked this pull request as ready for review July 18, 2024 15:24
Copy link
Member

@zelig zelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this functionality too work,

  • pullsync needs to process each instance of the soc on the same address.

    • if a soc has the same postage sstamp as an earlier one, the node it is pushsynced to might not even save it and therefore will not offer it via pullsync
    • with different postage stamp but same soc address the soc should be saved and offered via pullsync and the downstrream party should request and save it

    -pushsync should never skip pushing the same soc addresss with different payload

    these assumptions need to be doublechecked to be sure the functionality makes sense.
    it shooould also be properly going through a SWIP

pkg/gsoc/gsoc.go Outdated Show resolved Hide resolved
pkg/gsoc/gsoc.go Show resolved Hide resolved
pkg/gsoc/gsoc.go Outdated Show resolved Hide resolved
pkg/pullsync/pullsync.go Outdated Show resolved Hide resolved
pkg/pushsync/pushsync.go Outdated Show resolved Hide resolved
pkg/pushsync/pushsync_test.go Outdated Show resolved Hide resolved
pkg/api/gsoc_test.go Outdated Show resolved Hide resolved
pkg/api/gsoc_test.go Outdated Show resolved Hide resolved
@zelig
Copy link
Member

zelig commented Sep 19, 2024

this has failing CI checks @nugaon and my global concern is not responded to.

@nugaon nugaon force-pushed the feat/gsoc-subscribe branch 2 times, most recently from 6166bf1 to 450d973 Compare October 18, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscribe to specific SOC address
3 participants