Fixes Typing errors for points at infinity (NoneTypes) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlBeek
commented
Mar 30, 2020
py_ecc/fields/field_elements.py
Outdated
| @@ -201,7 +201,7 @@ class FQP(object): | |||
|
|
|||
| def __init__(self, | |||
| coeffs: Sequence[IntOrFQ], | |||
| modulus_coeffs: Sequence[IntOrFQ] = None) -> None: | |||
| modulus_coeffs: Sequence[IntOrFQ] = []) -> None: | |||
There was a problem hiding this comment.
This is to handle a separate error where len(modulus_coeffs) is called in line 208 below. This is not possible with None as it has no __len__. The reason for having a default argument here is for simple type(self) calls.
| @@ -64,8 +65,8 @@ | |||
| bls12_381_FQ2, | |||
| bls12_381_FQ12, | |||
| ) | |||
| Point2D = Tuple[Field, Field] | |||
| Point3D = Tuple[Field, Field, Field] | |||
| Point2D = Optional[Tuple[Field, Field]] # Point at infinity is encoded as a None | |||
There was a problem hiding this comment.
This is the meat of this PR and addresses 48 type errors.
Side note, should extended type checking be a part of CI on this repo? I feel like it should.
There was a problem hiding this comment.
I opened issue #95 for this.
2 tasks
hwwhww
reviewed
May 6, 2020
Co-authored-by: Hsiao-Wei Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The point at infinity on any given curve is encoded as
None. MyPy was not informed.How was it fixed?
I told MyPy.
Cute Animal Picture