Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wallet.sol at solidity v0.4.21 #87

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update wallet.sol at solidity v0.4.21 #87

wants to merge 2 commits into from

Conversation

JhChoy
Copy link

@JhChoy JhChoy commented Mar 19, 2018

Apply:
0.4.10 -> 0.4.21
'var' deprecated
use 'public'
mark 'emit'
sha3(deprecated) -> keccak256

JhChoy and others added 2 commits March 19, 2018 13:24
@JhChoy
Update wallet.sol at solidity v0.4.21
e2167fa 
Apply:
 0.4.10 -> 0.4.21
 'var' deprecated
 use 'public'
 mark 'emit'
 sha3(deprecated) -> keccak256
@JhChoy
fix bug
1effb64
tomvanbraeckel
tomvanbraeckel reviewed Sep 6, 2018
View reviewed changes
Copy link

@tomvanbraeckel tomvanbraeckel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not compile:

modifier onlymanyowners(bytes32 _operation) {
    if(confirmAndCheck(_operation));
        _;
}

=> "ParserError: Expected primary expression."

Also, how does this fix a bug, exactly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomvanbraeckel tomvanbraeckel tomvanbraeckel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JhChoy @tomvanbraeckel