Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swan Chain Mainnet #638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanielW8088
Copy link

Adding a New Chain

This PR adds Swan chain mainnet to the registry.

Checklist

  • I have declared the chain at the appropriate Superchain Level.
  • I have run just validate <chain-id> locally to ensure all local validation checks pass.
  • I have run just codegen to ensure that the chainlist and other generated files are up-to-date and include my chain.

@DanielW8088 DanielW8088 changed the title feat: add Swan chain mainnet to the Superchain Registry Add Swan Chain Mainnet Oct 17, 2024
Copy link
Collaborator

@sbvegan sbvegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we need to update our internal notes because swan chain is non-standard. It looks like this chain is running with 5s blocktimes and the latest hardforks are not activated yet. @Wazabie can you update Hubspot and our tracker when you get a chance?

"SequencerRPC": "https://sequencer-mainnet.swanchain.org",
"Explorer": "https://swanscan.io",
"SuperchainLevel": 0,
"StandardChainCandidate": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have in our internal notes that Swan Chain is supposed to be a standard chain, are our notes incorrect?

"Chain": "swan",
"canyon_time": 0,
"delta_time": 0,
"block_time": 5,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay our notes must be wrong, because a 5s block time is not standard: https://specs.optimism.io/protocol/configurability.html#l2-block-time

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, our block time is 5 seconds.

@sbvegan sbvegan added the M-new-chain-request Meta: New Chain Request label Oct 17, 2024
@DanielW8088 DanielW8088 marked this pull request as ready for review October 18, 2024 13:29
@DanielW8088 DanielW8088 requested a review from a team as a code owner October 18, 2024 13:29
@Wazabie Wazabie added the F-do-not-merge Flag: Do Not Merge label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-do-not-merge Flag: Do Not Merge M-new-chain-request Meta: New Chain Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants