Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cyber Mainnet #625

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

atenjin
Copy link
Contributor

@atenjin atenjin commented Oct 8, 2024

Adding a New Chain

This PR adds Cyber Mainnet to the registry.

Checklist

  • I have declared the chain at the appropriate Superchain Level.
  • I have run just validate <chain-id> locally to ensure all local validation checks pass.
  • I have run just codegen to ensure that the chainlist and other generated files are up-to-date and include my chain.

@atenjin atenjin requested a review from a team as a code owner October 8, 2024 16:16
@atenjin
Copy link
Contributor Author

atenjin commented Oct 8, 2024

Notice:
When cyber mainnet launching, we set daChallengeWindow and daResolveWindow to 1 at genesis, however op requires us to set to 3600(12hour) later. Then we updated those two value in rollup.json, and update the value in l1 contract (DataAvailabilityChallengeProxy 0x10E34EfE14E4D270C0f77Bf1aF01b6C832161B49)

While for this pr, in deploy-config.json I still keep the old value, but pass the ci.
If you require us to update deploy-config.json for this value, please ping me, I will update for it.
Thanks.

@Wazabie Wazabie self-assigned this Oct 11, 2024
@Wazabie Wazabie added F-do-not-merge Flag: Do Not Merge M-new-chain-request Meta: New Chain Request labels Oct 11, 2024
@sbvegan sbvegan removed the F-do-not-merge Flag: Do Not Merge label Oct 16, 2024
@parkgunou parkgunou requested review from a team and removed request for a team October 16, 2024 22:48
@parkgunou parkgunou removed the request for review from bitwiseguy October 16, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-new-chain-request Meta: New Chain Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants