-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rehearsal 5 #239
Draft
maurelian
wants to merge
20
commits into
main
Choose a base branch
from
maur/guardian-rehearsal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Rehearsal 5 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurelian
force-pushed
the
maur/guardian-rehearsal
branch
2 times, most recently
from
June 25, 2024 19:11
99b5b78
to
dd731d5
Compare
maurelian
force-pushed
the
maur/guardian-rehearsal
branch
from
June 27, 2024 03:38
dc002b8
to
72b6ccf
Compare
mds1
reviewed
Jun 27, 2024
mds1
reviewed
Jun 27, 2024
mds1
reviewed
Jun 27, 2024
mds1
reviewed
Jun 27, 2024
mds1
reviewed
Jun 27, 2024
mds1
reviewed
Jun 27, 2024
mds1
reviewed
Jun 27, 2024
mds1
reviewed
Jun 27, 2024
maurelian
requested review from
sbvegan,
blmalone,
awilliams1-cb,
anikaraghu and
emrahCoinbase
as code owners
July 18, 2024 19:57
maurelian
force-pushed
the
maur/guardian-rehearsal
branch
from
July 18, 2024 19:57
4a017eb
to
ca84120
Compare
maurelian
commented
Jul 18, 2024
maurelian
force-pushed
the
maur/guardian-rehearsal
branch
from
July 18, 2024 20:16
ca84120
to
a8207f1
Compare
maurelian
commented
Jul 18, 2024
@@ -0,0 +1,9 @@ | |||
# Modify these values according to the Rehearsal instructions | |||
COUNCIL_SAFE=0xAB23dE0DbE0aedF356af3F815c8B47D88575D82d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This safe is the same as used in previous rehearsals, the SC lead prefers to use it.
maurelian
commented
Jul 18, 2024
# Modify these values according to the Rehearsal instructions | ||
COUNCIL_SAFE=0xAB23dE0DbE0aedF356af3F815c8B47D88575D82d | ||
GuardianSafe_ADDRESS=0x91dCf0F534B36218FE7926eac40089eF54006421 | ||
SuperchainConfig_ADDRESS=0xbEDBB0A4d75514c84D569977B14D400c2Af5b36D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been unable to verify either the Proxy or Implementation for this contract.
--wip-- wip Without Yul error
maurelian
force-pushed
the
maur/rename-r4-script
branch
from
July 26, 2024 19:31
ec27a0c
to
df62b8a
Compare
maurelian
force-pushed
the
maur/guardian-rehearsal
branch
from
July 26, 2024 19:34
43abb8b
to
6ed26ac
Compare
maurelian
force-pushed
the
maur/guardian-rehearsal
branch
from
July 26, 2024 19:39
6ed26ac
to
ad6dc7a
Compare
maurelian
force-pushed
the
maur/guardian-rehearsal
branch
from
July 26, 2024 19:54
09ad40e
to
c485e5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new template for Rehearsal 5.
By following the instructions in the template's README