fix: attestation with private-data dataRoot deprecated
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the updated config we use `privateData` instead of `dataRoot` in schemaEncoder reference --> https://base-sepolia.easscan.org/schema/view/0x20351f973fdec1478924c89dfa533d8f872defa108d9c3c6512267d7e7e5dbc2
lbeder
approved these changes
Aug 14, 2024
|
Thanks @Vib-UX! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Documentation for Schema Encoder to Reflect
privateDataUsageDescription
This pull request updates the documentation to replace references from
dataRoottoprivateDatain theSchemaEncoderusage. This change aligns with the latest configuration updates in the Ethereum Attestation Service (EAS) SDK.Changes
SchemaEncoderinitialization from'bytes32 dataRoot'to'bytes32 privateData'.Justification
Using
privateDataas the field name in theSchemaEncoderis now the standard practice according to the updated EAS SDK guidelines. This documentation update ensures our guidance is clear, accurate, and aligned with the latest standards.Reference
The updated schema configuration using
privateDatacan be viewed here:View Schema Configuration
Impact
This change is strictly related to documentation and does not affect the actual codebase functionality. It improves clarity for developers using our documentation to implement EAS in their projects.
Testing
Not applicable as the changes are confined to documentation.
Fixes
This PR fixes Issue #112 on the EAS SDK repository.
This update ensures documentation reflects the current practices and supports developers in correctly implementing attestation services using the EAS SDK.