Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue#176: document yarn add expo for devs #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

issue#176: document yarn add expo for devs #177

wants to merge 1 commit into from

Conversation

jzacsh
Copy link

@jzacsh jzacsh commented Aug 1, 2021 •
edited
Loading

(WIP) things I think would be helpful to cover:

  1. call out yarn add expo that tasn explained
  2. replace probably(?)-copy-pasta repo URL in the instructoins with etesync org
  3. should probably actually explain that yarn add expo's corresponding
    package.json,yarn.lock changes should be ignored and not accidentally
    committed.
  4. explain if/should you have started a etebase backend (and if so, link to the right repo's instructions)
  5. should explain how to setup a fake account/backend (so you're not local-testing against your personal prod data)

@jzacsh
issue#176: document yarn add expo for devs
044c2be 
(WIP) commit - should probably actually explain that corresponding
package.json,yarn.lock changes should be ignored and not accidentally
committed.
@tasn tasn linked an issue Aug 2, 2021 that may be closed by this pull request
following README's dev instructions results fails (at least for me) #176
Open
@tasn
Copy link
Member

tasn commented Aug 2, 2021

I think the last two are probably not needed in detail. But rather have a mention about it and point to the server repo for how to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

following README's dev instructions results fails (at least for me)
2 participants
@jzacsh @tasn