Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

following README's dev instructions results fails (at least for me) #176

Open
jzacsh opened this issue Aug 1, 2021 · 3 comments · May be fixed by #177
Open

following README's dev instructions results fails (at least for me) #176

jzacsh opened this issue Aug 1, 2021 · 3 comments · May be fixed by #177

Comments

@jzacsh
Copy link

jzacsh commented Aug 1, 2021

yarn web results in:

yarn run v1.22.11
$ expo start --web
Starting project at /tmp/src/etesync-notes
Unable to find expo in this project - have you run yarn / npm install yet?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

note i've had yarn run successfully, as well as npm install (trying to follow the above error's expo hint)

$ npm --version && yarn --version && expo-cli --version
7.20.3
1.22.11
4.9.1

possible lead: is it correct that the READMe says to have both yarn and npm installed?

tdl;dr maybe this is a "support" ticket (in which case, feel free to close it - i'm happy to try debugging live in the matrix room instead) but maybe something's off with the readme? wanna double-check before i investigate further

@tasn
Copy link
Member

tasn commented Aug 1, 2021

npm install may have littered your env.

Start from a fresh directory and follow the prerequisites - https://github.com/etesync/etesync-notes#prerequisites

I think the issue you are facing (and we should probably update the readme!) is that developing the web requires yarn add expo. We are however not adding this dep permanently because it adds non-free components to the Android and iOS bulids which we don't want.

@jzacsh jzacsh linked a pull request Aug 1, 2021 that will close this issue
5 tasks
@jzacsh
Copy link
Author

jzacsh commented Aug 1, 2021

Thanks, that worked and indeed I'm able to see the UI on localhost now.

I've started a pull request with the update to the readme you mention, and threw in a few other TODOs that might be helpful for me to figure out and include before I close that PR.

@tasn tasn linked a pull request Aug 2, 2021 that will close this issue
5 tasks
@tasn
Copy link
Member

tasn commented Aug 2, 2021

Great to hear! Cool, let me know once the PR is ready to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants