-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improving text for transactional write #905
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NavinShrinivas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @NavinShrinivas. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7444fc5
to
5b6263a
Compare
Hi @NavinShrinivas, I just read about this PR in the #sig-etcd channel. Let's run the linter as a first pass, then I'll deliver a review 😄 /ok-to-test |
/retest |
1 similar comment
/retest |
Signed-off-by: Navin Shrinivas <[email protected]>
Signed-off-by: Navin Shrinivas <[email protected]>
Signed-off-by: Navin Shrinivas <[email protected]>
@NavinShrinivas, sorry for the late response. Please refer to #901 (comment) |
Pertains to issue #901. Doesn't have the GIF/video example attached. The text added in this PR is picked from the API documentation and I felt its relevant here as well.