-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable go-require rule from testifylint #18827
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Matthieu MOREL <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorel-35 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @ahrtr |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #18827 +/- ##
==========================================
- Coverage 68.79% 68.74% -0.05%
==========================================
Files 420 420
Lines 35523 35523
==========================================
- Hits 24437 24421 -16
- Misses 9658 9670 +12
- Partials 1428 1432 +4 Continue to review full report in Codecov by Sentry.
|
This fixes go-require rule from testifylint
Closes #18719