-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use require instead of t.Fatal(err) in tests/e2e package #18821
base: main
Are you sure you want to change the base?
fix: use require instead of t.Fatal(err) in tests/e2e package #18821
Conversation
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c17a82e
to
ba00f4b
Compare
/assign @spzala |
ba00f4b
to
c3c31ee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 15 files with indirect coverage changes @@ Coverage Diff @@
## main #18821 +/- ##
==========================================
- Coverage 68.78% 68.76% -0.02%
==========================================
Files 420 420
Lines 35523 35523
==========================================
- Hits 24433 24429 -4
- Misses 9665 9667 +2
- Partials 1425 1427 +2 Continue to review full report in Codecov by Sentry.
|
c3c31ee
to
b73c4c4
Compare
7745c1a
to
7c6e774
Compare
/assign @ahrtr |
/ok-to-test |
7c6e774
to
ff9ac82
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorel-35 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ff9ac82
to
7f2d0fa
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
7f2d0fa
to
dfd1ddb
Compare
@mmorel-35: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This uses testify instead of testing for t.Fatal calls