Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed staging deployment happening with prod deployment #1658

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Un3x
Copy link
Contributor

@Un3x Un3x commented Sep 9, 2024

This might have lead to weird errors in staging since it used the production environment configuration.
Also reduces the consumption of the CI.

@Un3x Un3x requested a review from skelz0r September 9, 2024 13:33
@Un3x
Copy link
Contributor Author

Un3x commented Sep 9, 2024

@Samuelfaure FYI

@skelz0r
Copy link
Member

skelz0r commented Sep 9, 2024

Plus de déploiement en staging ?

@Un3x
Copy link
Contributor Author

Un3x commented Sep 9, 2024

Si, mais là c'est la pipeline de déploiement en production.

@Samuelfaure
Copy link
Contributor

ah bah ouais j'ai c/c le script de deploy en prod 🙄

This might have lead to weird errors in staging since it used the
production environment configuration
@Un3x Un3x force-pushed the removed-deployment-of-staging-while-on-production branch from b5f2558 to 40c0f6d Compare September 16, 2024 07:50
@skelz0r
Copy link
Member

skelz0r commented Sep 16, 2024

Pourquoi ne pas avoir supprimer le job ligne 143 ?

@Un3x
Copy link
Contributor Author

Un3x commented Sep 16, 2024

Parce que la valeur de l'environnement est pas la même.

@skelz0r skelz0r merged commit eb99cde into develop Sep 16, 2024
9 checks passed
@skelz0r skelz0r deleted the removed-deployment-of-staging-while-on-production branch September 16, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants