Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "source-mysql: Set ReadTimeout/WriteTimeout on connection" #2074

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

willdonnelly
Copy link
Member

@willdonnelly willdonnelly commented Oct 22, 2024

Reverts #2073

Somehow the read/write timeouts appear to be set once and then somehow getting stuck -- captures consistently start up and then fail exactly one minute after the initial database connection.


This change is Reviewable

@willdonnelly willdonnelly requested a review from a team October 22, 2024 20:57
@willdonnelly willdonnelly added the change:unplanned Unplanned change, useful for things like doc updates label Oct 22, 2024
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willdonnelly willdonnelly merged commit 5bd84f2 into main Oct 22, 2024
52 of 53 checks passed
@willdonnelly willdonnelly deleted the revert-2073-wgd/mysql-packet-timeouts-20241022 branch October 22, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned Unplanned change, useful for things like doc updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants