source-hubspot-native: add "FORWARD" to email event types #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Bair
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
An existing task is failing because email events it's receiving have a
FORWARDtype, which isn't allow in the model. This PR addsFORWARDas an allowed email event type.Relevant HubSpot docs are here. Skimming through them, we may need to add more email event types in the future (
PRINT? ), but that can be done later if needed.Discover snapshot changes are expected since a new email event type was added to the
EmailEventmodel.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
I haven't been able to test this locally yet due to issues with
flowctlI'm hitting this morning, but this feels like a pretty clear cut issue & solution that could probably be safely merged without testing on a local stack. If you think otherwise, LMK and I'll hold off until I can test locally.This change is