source-hubspot-native: custom object path components #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some HubSpot endpoints like /v3/properties/{objectType} do not work for
every custom object type. However, these endpoints do work if we prepend
a "p_" to the beginning of the custom object name and use that in the
path instead.
Alex-Bair
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some HubSpot endpoints like
/v3/properties/{objectType}do not work for every custom object type. However, these endpoints do work if we prepend ap_to the beginning of the custom object name and use that in the path instead.I chose to add
path_componentto thecrm_object_with_associationsfunction signature mainly so we only prependp_in one spot rather than in two. I'm not dead-set on this approach though, and I can adjust if there's a better/more desireable solution.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested on a local stack. Confirmed custom objects and their properties are retrieved from HubSpot.
This change is