materialize: boilerplate validator recommends explicit projections among ambiguous fields #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ong ambiguous fields A common case for user-defined projections are to change the capitalization of a field. For systems that do not allow identical-except-for-capitalization named fields, this is unfortunate because the user-defined explicit projection is currently getting marked as optional even if it would otherwise be recommended, since the field names only differ in capitalization. This change has us recommend explicit projections if they would otherwise be recommended even if their field name is ambiguous with others. It is relatively simple to do so since the Flow build process will not allow projected field names that differ only in capitalization, so we know if there is an explicit projection it's the only one with those case-insensitive characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A common case for user-defined projections are to change the capitalization of a field. For systems that do not allow identical-except-for-capitalization named fields, this is unfortunate because the user-defined explicit projection is currently getting marked as optional even if it would otherwise be recommended, since the field names only differ in capitalization.
This change has us recommend explicit projections if they would otherwise be recommended even if their field name is ambiguous with others. It is relatively simple to do so since the Flow build process will not allow projected field names that differ only in capitalization, so we know if there is an explicit projection it's the only one with those case-insensitive characters.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is