source-pendo: separate backfill from incremental #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Pendo accounts with a significant amount of data, the strategy of
asking for all data up until the present does not work. Pendo's response
time is long enough to cause TimeoutErrors, and responses that are
received end up OOM-ing the connector.
To fix this, there is now a distinct backfill process for events and
aggregated events. Notable changes include:
- Separating backfills from ongoing incremental replication.
- Backfills try to get at max a day's worth of data. Incremental
replication continues to get all data up to the present.
- The cutoff between backfills and incremental replication is shifted
backwards 12 hours due to delays between when an event occurred and
when it is available in the API.
- The Pendo API response limit is increased to 50k. This might be able
to be increased, but I've done limited testing to confirm 50k won't
OOM the connector.
- API responses are now sorted first by timestamp and next by resource
ID. This lets us more effectively "paginate" through documents if
multiple occur at the same timestamp.
- If all the documents in a given API response have the same timestamp,
the connector will fetch the remaining documents with that exact
timestamp before incrementing the connector by a millisecond.
Events don't show up in the Pendo API until 45+ minutes after they occur. Increasing the Events interval to align with the Aggregated Events interval makes sense because of this API lag.
Alex-Bair
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For Pendo accounts with a significant amount of data, the strategy of asking for all data up until the present does not work. Pendo's response time is long enough to cause
TimeoutErrors, and responses that are received end up OOM-ing the connector.To fix this, there is now a distinct backfill process for events and aggregated events.
Notable changes include:
Discover snapshot change is expected due to the increased interval for event streams.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested on a local stack. Confirmed:
Sometimes, Pendo's API takes too long to response to a given query, even a simple/small query. These cause intermittent
TimeoutErrors, but the connector makes progress after restarting & re-querying the API.All existing tasks will need their event & aggregated events streams backfilled after merging.
This change is