materialize-pinecone: update to Pinecone Go SDK #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates our connector to use the Pinecone Go SDK, which will allow support for serverless indices, among other things. Also a few updates that I have made at my discretion, since now seems like a good time to make updates: * We will require a namespace input for the resource config. It's no longer possible to create a Pinecone index that doesn't support namespaces. * Various checks related to Pinecone indexes that don't support namespaces are removed, since that isn't possible anymore. * Include the configured index name in the resource path, in case we ever want to support multiple indices in the same materialization. This is sort of like Pinecone's concept of a "schema", so we'll probably want to do this. * Hex-encode embedding document keys, since that is what we do for other materializations like this. * Implement batch flushing after the Store iterator ticks over to the next binding.
mdibaiee
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This updates our connector to use the Pinecone Go SDK, which will allow support for serverless indices, among other things.
Also a few updates that I have made at my discretion, since now seems like a good time to make updates:
Closes #2022
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is