Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

materialize-snowflake: limit number of retries based on pipe numbers #2002

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Oct 1, 2024

Description:

  • when tasks have a large number of bindings, we keep retrying for too long. In cases where the ingestion reports are expired, this creates a forever loop. This pull-request limits the length of time we retry to 5 minutes maximum.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

Comment on lines +727 to +729
if len(pipes) > 0 {
// 5 minutes divided by three seconds for each pipe
var maxTries = (5 * 60) / (3 * len(pipes))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the real changes, the rest is indentation

Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdibaiee mdibaiee merged commit b738d6a into main Oct 1, 2024
49 of 53 checks passed
@mdibaiee mdibaiee deleted the mahdi/snowflake-pipe-time branch October 1, 2024 18:04
@mdibaiee mdibaiee added the change:emergency This change is an emergency label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:emergency This change is an emergency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants