Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-linkedin-ads: nit: fixing oauth provider spec #1984

Merged
merged 2 commits into from
Sep 26, 2024
Merged

source-linkedin-ads: nit: fixing oauth provider spec #1984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fe6e9e
source-linkedin-ads: nit: fixing oauth provider spec
Luishfs Sep 26, 2024
fd9e43f
source-linkedin-ads: nit: removing unused logging
Luishfs Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source-linkedin-ads-v2/source_linkedin_ads_v2/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
{
"type": "object",
"title": "OAuth2.0",
"x-oauth-provider": "linkedin",
"x-oauth2-provider": "linkedin",
"required": ["auth_method", "client_id", "client_secret", "refresh_token"],
"properties": {
"auth_method": {
Expand Down
2 changes: 0 additions & 2 deletions source-linkedin-ads-v2/source_linkedin_ads_v2/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,7 @@ def _date_time_to_rfc3339(self, record: MutableMapping[str, Any]) -> MutableMapp
Transform 'date-time' items to RFC3339 format
"""
for item in record:
self.logger.error(f"{record}")
if item in self.date_time_fields and record[item]:
self.logger.error(f"{record[item]}")
record[item] = pendulum.parse(record[item]).to_rfc3339_string()
return record

Expand Down
2 changes: 1 addition & 1 deletion ...v2/tests/snapshots/source_linkedin_ads_v2_tests_test_snapshots__spec__capture.stdout.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
],
"title": "OAuth2.0",
"type": "object",
"x-oauth-provider": "linkedin"
"x-oauth2-provider": "linkedin"
},
{
"properties": {
Expand Down
Loading