source-klaviyo: updating schemas to minimal schema #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luishfs
changed the title
Alex-Bair
approved these changes
Oct 9, 2024
| @@ -4,80 +4,6 @@ | |||
| "additionalProperties": true, | |||
| "required": ["id"], | |||
| "properties": { | |||
| "type": { "type": "string" }, | |||
| "id": { "type": "string" }, | |||
| "datetime": { "type": "string", "format": "date-time" }, | |||
There was a problem hiding this comment.
datetime is the cursor field for the events stream, right? I don't think omitting it here will cause an issue, but
I don't think leaving the cursor field in shouldn't cause a problem since we're relying on it being in every document.
There was a problem hiding this comment.
@Alex-Bair There actually was a error with cursor fields being defined in the schema, which caused this PR to be created. I think it was more related to their schema being set as nullable, but in order to be sure i just simply remove then now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
(Describe the high level scope of new or changed features)
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is