source-impact-native: switching snapshots pk to _meta/row_id

after fixing the tombstone value with the correct class, the connector still broke due to tombstone failures. The newer bugs happened because there were still a pk required that was not being fed to the newer tombstone model. In order to fix that, i've removed all previous pk from snapshot models and fixated all pks to _meta/row_id ( the default strategy )
estuary · Sep 25, 2024 · b9e8e6f · b9e8e6f
1 parent 9d75621
commit b9e8e6f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 54 deletions.
diff --git a/source-impact-native/source_impact_native/models.py b/source-impact-native/source_impact_native/models.py
@@ -64,19 +64,15 @@ class Ads(BaseDocument, extra="allow"):
     START_DATE_INCREMENTAL: ClassVar[str]  = None
     END_DATE: ClassVar[str] = ""
     REP_KEY: ClassVar[str] = ""
-    PRIMARY_KEY: ClassVar[str] = "/Id"
-
-    Id: str
+    PRIMARY_KEY: ClassVar[str] = "/_meta/row_id"
 
 class Catalogs(BaseDocument, extra="allow"):
     NAME: ClassVar[str] = "Catalogs"
     START_DATE: ClassVar[str] = ""
     START_DATE_INCREMENTAL: ClassVar[str]  = None
     END_DATE: ClassVar[str] = ""
     REP_KEY: ClassVar[str] = ""
-    PRIMARY_KEY: ClassVar[str] = "/Id"
-
-    Id: str
+    PRIMARY_KEY: ClassVar[str] = "/_meta/row_id"
 
 class Invoices(BaseDocument, extra="allow"):
     NAME: ClassVar[str] = "Invoices"
@@ -137,9 +133,8 @@ class Campaigns(BaseDocument, extra="allow"):
     START_DATE: ClassVar[str] = ""
     END_DATE: ClassVar[str] = ""
     REP_KEY: ClassVar[str] = ""
-    PRIMARY_KEY: ClassVar[str] = "/Id"
+    PRIMARY_KEY: ClassVar[str] = "/_meta/row_id"
 
-    Id: str
 
 class Reports(BaseDocument, extra="allow"):
     # No query parameters available, and no date replication key
@@ -167,9 +162,7 @@ class PhoneNumbers(BaseDocument, extra="allow"):
     START_DATE: ClassVar[str] = ""
     END_DATE: ClassVar[str] = ""
     REP_KEY: ClassVar[str] = "DateCreated"
-    PRIMARY_KEY: ClassVar[str] = "/Id"
-
-    Id: str
+    PRIMARY_KEY: ClassVar[str] = "/_meta/row_id"
 
 class PromoCodes(BaseDocument, extra="allow"):
     NAME: ClassVar[str] = "PromoCodes"
@@ -218,9 +211,7 @@ class MediaPartnerGroups(BaseDocument, extra="allow"):
     START_DATE: ClassVar[str] = ""
     END_DATE: ClassVar[str] = ""
     REP_KEY: ClassVar[str] = ""
-    PRIMARY_KEY: ClassVar[str] = "/Id"
-
-    Id: str
+    PRIMARY_KEY: ClassVar[str] = "/_meta/row_id"
 
 class Notes(BaseDocument, extra="allow"):
     NAME: ClassVar[str] = "Notes"

diff --git a/...t-native/tests/snapshots/source_impact_native_tests_test_snapshots__discover__stdout.json b/...t-native/tests/snapshots/source_impact_native_tests_test_snapshots__discover__stdout.json
@@ -592,21 +592,14 @@
             "row_id": -1
           },
           "description": "Document metadata"
-        },
-        "Id": {
-          "title": "Id",
-          "type": "string"
         }
       },
-      "required": [
-        "Id"
-      ],
       "title": "Campaigns",
       "type": "object",
       "x-infer-schema": true
     },
     "key": [
-      "/Id"
+      "/_meta/row_id"
     ]
   },
   {
@@ -653,21 +646,14 @@
             "row_id": -1
           },
           "description": "Document metadata"
-        },
-        "Id": {
-          "title": "Id",
-          "type": "string"
         }
       },
-      "required": [
-        "Id"
-      ],
       "title": "Ads",
       "type": "object",
       "x-infer-schema": true
     },
     "key": [
-      "/Id"
+      "/_meta/row_id"
     ]
   },
   {
@@ -714,21 +700,14 @@
             "row_id": -1
           },
           "description": "Document metadata"
-        },
-        "Id": {
-          "title": "Id",
-          "type": "string"
         }
       },
-      "required": [
-        "Id"
-      ],
       "title": "Catalogs",
       "type": "object",
       "x-infer-schema": true
     },
     "key": [
-      "/Id"
+      "/_meta/row_id"
     ]
   },
   {
@@ -829,21 +808,14 @@
             "row_id": -1
           },
           "description": "Document metadata"
-        },
-        "Id": {
-          "title": "Id",
-          "type": "string"
         }
       },
-      "required": [
-        "Id"
-      ],
       "title": "PhoneNumbers",
       "type": "object",
       "x-infer-schema": true
     },
     "key": [
-      "/Id"
+      "/_meta/row_id"
     ]
   },
   {
@@ -1134,21 +1106,14 @@
             "row_id": -1
           },
           "description": "Document metadata"
-        },
-        "Id": {
-          "title": "Id",
-          "type": "string"
         }
       },
-      "required": [
-        "Id"
-      ],
       "title": "MediaPartnerGroups",
       "type": "object",
       "x-infer-schema": true
     },
     "key": [
-      "/Id"
+      "/_meta/row_id"
     ]
   }
 ]