Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sameContentLocale option to filter content relationship suggestions #864

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

wottpal
Copy link

@wottpal wottpal commented Oct 7, 2024

Closes #851.

Changes

  • Fixes issue where content relationship suggestions (combobox options) where incorrectly filtered by fmContentType (cause: fuse threshold)
  • Minor display improvement: Show slug as subtitle in combobox option
  • Add option sameContentLocale (defaults to true*) that, if set, filters content relationship suggestions by the active locale of the currently edited file.

*Happy to discuss the default here as it changes the current behavior. I think the scenarios where you actually add relations to files with different locales are very uncommon.

Screenshot

CleanShot 2024-10-07 at 10 56 21@2x

@estruyf estruyf changed the base branch from main to beta October 7, 2024 19:36
@estruyf
Copy link
Owner

estruyf commented Oct 7, 2024

@wottpal I believe it makes sense to change the default behavior, as, like you mentioned, it might be uncommon to select other locales. Checking out the changes.

@estruyf estruyf merged commit 17860a1 into estruyf:beta Oct 7, 2024
3 checks passed
@estruyf
Copy link
Owner

estruyf commented Oct 7, 2024

@wottpal great job 👌 - added it to the latest beta version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Ability to restrict contentRelationship suggestions to same locale
2 participants