User Configuration of Read/Write Commands in Modbus Master (IDFGH-11983) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the parameter descriptor if they aren't set to NONE
… the parameter descriptor if they aren't set to NONERenamed Commands NONE to AUTO
…ter_descriptor table
|
|
github-actions
bot
changed the title
|
Please see my comments here. |
espressif-bot
added
Status: Done
Resolution: Won't Do
and removed
Status: Opened
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the commands would be automatically determined by the library, however some devices do not support all Modbus Commands.
This PR would allow the library to send all possible Commands based on user provided Configuration.
Affects both Serial and TCP.
Addresses Issue 48