Jeetrohan mpu60xx 1 (BSP-568) #416
Conversation
manifest file for mpu60xx driver
example C source file for using inbuilt motion detection.
Manifest file for mpu60xx_motion_detection example
CMakeLists for mpu60xx_motion_detect
|
|
There was a problem hiding this comment.
@jeetrohan That's a pretty good job for your first contribution!
| idf_component_register(SRCS "mpu60xx.c" | ||
| INCLUDE_DIRS "include") |
There was a problem hiding this comment.
My initial idea was to release this version as v2.0.0 of the original mpu6050 component.
This way we won't have 2 driver for the same device...
|
|
||
| set(COMPONENTS main) | ||
| include($ENV{IDF_PATH}/tools/cmake/project.cmake) | ||
| project(mpu60xx_motion_detect) |
There was a problem hiding this comment.
Thanks for the example!
| maintainers: | ||
| - "Rohan Jeet <[email protected]>" |
There was a problem hiding this comment.
This is the most important thing we need to agree on.
If you list yourself as a maintainer, then all bugs and feature request will go your way. You should only add this, if you want to commit yourself to maintenance. It's also possible to list you as 'author' and Espressif will take care of the maintenance.
I can also see that you did not add a license to this new component. All components in this repo must be Apache-2 licensed (that is every one can use for free). If you, as author, require more strict license you will have to publish it in your own repository.
So the bottom line is: if you want to maintain, or don't want to release under Apache-2, or want to release this independently from the original mpu6050, I'd suggest releasing the component on your own.
If all of the above is false, we can review and merge in esp-bsp :)
| dependencies: | ||
| ## Required IDF version | ||
| idf: | ||
| version: ">=4.1.0" |
There was a problem hiding this comment.
the new I2C driver was added in v5.2
| version: ">=4.1.0" | |
| version: ">=5.2.0" |
ESP-BSP Pull Request checklist
Change description
A new mpu60xx library which uses the new I2C driver for reading raw and floating point values; from accelerometer, gyrometer and temperature sensor.
Added functionality to use inbuilt motion detection on mpu60xx using both, polling and interrupts.