Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stop_transfer method to DMA driver #2236

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Dominaezzz
Copy link
Collaborator

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Adds a stop transfer method to the DMA driver.
I added one in #2191 but I need it for another PR, so I'm sending it in earlier.

This method is internal, so no changelog.

Testing

It's a straight forward change already tested in #2191 and doesn't affect any existing code.

@Dominaezzz Dominaezzz added the skip-changelog No changelog modification needed label Sep 26, 2024
Copy link
Contributor

@bugadani bugadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess this is a bit more polite than resetting the whole thing :D I'll try and use this is the other stuff, thank you!

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@SergioGasquez SergioGasquez added this pull request to the merge queue Sep 26, 2024
Merged via the queue into esp-rs:main with commit 00d892b Sep 26, 2024
29 checks passed
@Dominaezzz Dominaezzz deleted the add_stop_to_dma branch September 30, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants