Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid moving inside SpiDmaBus, abort dropped transfers #2216

Merged
merged 19 commits into from
Oct 7, 2024
Merged

Avoid moving inside SpiDmaBus, abort dropped transfers #2216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a76eb70
Drop State from DMA
bugadani Sep 23, 2024
0fa2b06
Simplify Error paths
bugadani Sep 23, 2024
4c7fd67
Cancel dropped transfers, fix and test
bugadani Sep 23, 2024
023b37e
Fix C6
bugadani Sep 23, 2024
0e29087
Avoid cancelling a completed transaction
bugadani Sep 23, 2024
87d61b6
Do not implement DmaTxRxBuf for references
bugadani Sep 24, 2024
a7c46d9
Remove unnecessary import
bugadani Sep 24, 2024
ebcdbd1
Merge BufferRef structs
bugadani Sep 24, 2024
df2efeb
Move wait impl to the peripheral
bugadani Sep 24, 2024
525b592
Allow the current byte to complete
bugadani Sep 24, 2024
612fb2a
Restore SpiDmaTransfer::is_done
bugadani Sep 24, 2024
97b7238
Explain cancel code
bugadani Sep 24, 2024
f1da457
Fix test formatting
bugadani Sep 24, 2024
877946a
Changelog
bugadani Sep 25, 2024
01b966e
Simplify implementation
bugadani Sep 27, 2024
ae4b3fd
Make sure everything gets dropped
bugadani Sep 30, 2024
0a3a313
Remove unnecessary PhantomData
bugadani Sep 30, 2024
fad1364
Remove OptionalFuture
bugadani Oct 3, 2024
3b40895
Adjust test to a more realistic clock frequency
bugadani Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions esp-hal/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `EspTwaiFrame` constructors now accept any type that converts into `esp_hal::twai::Id` (#2207)
- Change `DmaTxBuf` to support PSRAM on `esp32s3` (#2161)
- I2c `transaction` is now also available as a inherent function, lift size limit on `write`,`read` and `write_read` (#2262)
- SPI transactions are now cancelled if the transfer object (or async Future) is dropped. (#2216)

### Fixed

Expand Down
Loading