Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chip-specific features for tests/examples #2175

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Add chip-specific features for tests/examples #2175

merged 3 commits into from
Sep 23, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani added the skip-changelog No changelog modification needed label Sep 17, 2024
@bugadani bugadani marked this pull request as ready for review September 17, 2024 13:18
@bugadani bugadani mentioned this pull request Sep 17, 2024
Merged
6 tasks
bjoernQ
bjoernQ reviewed Sep 19, 2024
View reviewed changes
xtask/src/lib.rs

// The trailing ':' on metadata keys is optional :)
Copy link
Contributor

@bjoernQ bjoernQ Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically a change but given I didn't even know this I guess that is totally fine

bjoernQ
bjoernQ reviewed Sep 19, 2024
View reviewed changes
xtask/src/lib.rs

for chip in chips {
chip_features.insert(chip, values.clone());
}
} else {
log::warn!("Unrecognized metadata key '{key}', ignoring");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but we might consider to make this an hard error and panic - took we a while to recognize I was testing with CHIP_FEATURE(esp32s3) 😄

bjoernQ
bjoernQ approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine - not sure we should mention this in the README since it's not yet used anywhere (so it's hard to discover)

JurajSadel
JurajSadel approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Sep 23, 2024
Merged via the queue into esp-rs:main with commit d971d65 Sep 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JurajSadel JurajSadel JurajSadel approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bugadani @bjoernQ @JurajSadel @MabezDev