Avoid moving inside SpiDmaBus, abort dropped transfers (#2216)

* Drop State from DMA * Simplify Error paths * Cancel dropped transfers, fix and test * Fix C6 * Avoid cancelling a completed transaction * Do not implement DmaTxRxBuf for references * Remove unnecessary import * Merge BufferRef structs * Move wait impl to the peripheral * Allow the current byte to complete * Restore SpiDmaTransfer::is_done * Explain cancel code * Fix test formatting * Changelog * Simplify implementation * Make sure everything gets dropped * Remove unnecessary PhantomData * Remove OptionalFuture * Adjust test to a more realistic clock frequency
esp-rs · Oct 7, 2024 · 3e16c5c · 3e16c5c
1 parent e5bc639
commit 3e16c5c
Show file tree

Hide file tree

Showing 3 changed files with 656 additions and 509 deletions.
diff --git a/esp-hal/CHANGELOG.md b/esp-hal/CHANGELOG.md
@@ -62,6 +62,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `EspTwaiFrame` constructors now accept any type that converts into `esp_hal::twai::Id` (#2207)
 - Change `DmaTxBuf` to support PSRAM on `esp32s3` (#2161)
 - I2c `transaction` is now also available as a inherent function, lift size limit on `write`,`read` and `write_read` (#2262)
+- SPI transactions are now cancelled if the transfer object (or async Future) is dropped. (#2216)
 
 ### Fixed