This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
No longer notify on messages sent by yourself from different tab. Fixes #592 #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var settings = $.cookie("settings") || {}; | ||
| if (highlight || isQuery || (settings.notifyAllMessages && message)) { | ||
| if ((highlight || isQuery || (settings.notifyAllMessages && message)) && !self && !whois) { |
There was a problem hiding this comment.
Why not move this code down after checking ignore array so that the same filtering applies?
There was a problem hiding this comment.
True, I could probably change that part a bit since it's now doing some checks twice (such as whether or not the channel receiving the message is active or not). Once for the notification, and once for the badge.
|
Integrated xPaw's comment in this latest commit. As a result, you'll now also no longer receive a badge next to a channel if you were the one sending the message using a second client. |
| } | ||
| } | ||
|
|
||
| if (msg.self) { |
There was a problem hiding this comment.
You can have this if the first thing in the function.
|
👍 looks good |
ghost
mentioned this pull request
|
FYI, this is under review for The Lounge: thelounge/thelounge#6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages from yourself, or whois responses, no longer trigger a notification on a second client you may have running.