Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Fix show-more being displayed over chat messages. #568

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nomadturk
Copy link

With this PR I tried fixing #366 by changing it's position to relative. It wasn't a pretty sight to see "Show more" bar on existing chat messages.

Changed show-more position to from absolute to relative in style.css to avoid it being displayed over the existing text.
@nomadturk
Copy link
Author

Test image

@xPaw
Copy link
Contributor

xPaw commented Jan 23, 2016

There's this css which needs to be removed, otherwhise there's too much space with this change.

#chat .show-more.show + .messages .msg:first-child {
    padding-top: 47px !important;
}

#chat .show-more.show + .messages .msg:first-child > span {
    padding-top: 52px !important;
}

#chat .msg:first-child > span {
    padding-top: 10px;
}

@nomadturk
Copy link
Author

@xPaw , thanks for contributing. That's indeed way better.

Removed some css lines to get rid of extra empty lines above and below Show More button. Credits goes to xPaw
@xPaw
Copy link
Contributor

xPaw commented Jan 31, 2016

👍

@astorije astorije added the bug label Feb 1, 2016
@astorije astorije self-assigned this Feb 1, 2016
@astorije
Copy link
Collaborator

astorije commented Feb 1, 2016

@nomadturk, would you mind squashing these 2 commits please?
Thanks for this contribution! :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants