Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nifs attribute completion #1505

Closed
wants to merge 2 commits into from
Closed

Conversation

MarkoMin
Copy link
Contributor

@MarkoMin MarkoMin commented Apr 24, 2024

Description

Adds completion for -nifs attribute officially supported from OTP25

EDIT: dont merge yet, I have to fix completion inside "-nifs" attribute to behave similarly as inside "-export"

@MarkoMin
Copy link
Contributor Author

I pushed the solution, but tests are missing ATM. It's not as elegant as I hoped, but did my best. It doesn't exclude functions already defined as -nifs. I tried to do it, but ended up too deeply in els code. If you have an idea how do to this more elegant, I'm all ears.

Will add tests when I find more time

@plux
Copy link
Contributor

plux commented May 3, 2024

I tried out the feature locally and it works fine.

Seems like there some formatting issues.
Please run rebar3 fmt and commit the changes.

If you find time to write some tests that would also be awesome :)

@plux
Copy link
Contributor

plux commented Sep 18, 2024

I have opened a new PR for this here: #1537

@plux plux closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants